Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

025deg jra55do ryf.cherrypicks #103

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

anton-seaice
Copy link
Contributor

Companion PR to #91

This fails as there is no input/iced.1900-01-01-10800.nc in this configuration, as we use ice_ic=default. The iced file is expected by the setup user script.

We could just not use the setup user script, or change the user script, or make the initial condition file. Thoughts @dougiesquire ?

Flag OCN_modelio::pio_* params as unused in nuopc.runconfig

remove extra lines in nuopc.runconfig

update comment for ocean nc type
@anton-seaice anton-seaice changed the base branch from main to 025deg_jra55do_ryf August 21, 2024 06:25
@dougiesquire
Copy link
Collaborator

I think ditch the setup user script here. That's what we'll do for the other configs anyway once the symlink workaround is no longer required.

If you think it's important to make an initial condition file, that should be done in a subsequent PR

@anton-seaice anton-seaice force-pushed the 025deg_jra55do_ryf.cherrypicks branch 2 times, most recently from 0fc95c0 to 0bd3126 Compare August 22, 2024 05:30
@anton-seaice
Copy link
Contributor Author

I ran two adhoc tests:

  • with run length of 1 day, I did three 1 day runs to confirm that this reads restart files. From ice.log:
 Read ./rpointer.ice
 Using restart dump=./access-om3.cice.r.1900-01-02-00000.nc
 (ice_pio_init) opening file for reading ./access-om3.cice.r.1900-01-02-00000.nc
Restart read at istep=      64    1900-01-02-00000
  • with run length of 1 month, it concats the daily ice history output

@anton-seaice anton-seaice marked this pull request as ready for review August 22, 2024 23:02
@dougiesquire dougiesquire self-requested a review August 22, 2024 23:12
config.yaml Outdated Show resolved Hide resolved
manifests/restart.yaml Outdated Show resolved Hide resolved
nuopc.runconfig Outdated
@@ -288,13 +288,13 @@ CLOCK_attributes::
lnd_cpl_dt = 99999 #not used
ocn_cpl_dt = 1350 #ignored (coupling timestep set by nuopc.runseq) unless stop_option is nsteps
restart_n = 1
restart_option = nyears
restart_option = ndays
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to change this?

nuopc.runconfig Outdated Show resolved Hide resolved
dougiesquire and others added 3 commits August 23, 2024 15:14
- work-around symlink restart bug in CICE
- concatenate CICE daily output
- auto-generate an intake-esm datastore
…er at this point, and the userscript to concat ice daily output expects the default name to be used. See COSIMA/access-om3#201
@anton-seaice
Copy link
Contributor Author

Oops sorry - I fixed it. third time lucky!

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems to run successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants